kv/concurrency: remove synthetic timestamp handling in lockTableWaiter #117018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Informs cockroachdb#101938. This commit removes the handling of synthetic timestamps from the the lock-table waiter. The lock-table waiter used to handle the synthetic timestamp bit in two ways: 1. if set, it would propagate it on txn pushes 2. if set, it would would push txns above the local HLC clock, because observed timestamps from the clock would not be usable to avoid uncertainty with intents written at (or pushed to) synthetic timestamps. Neither of these behaviors are necessary anymore. We don't need to propagate the flag, because it has been deprecated since v22.2 and is no longer consulted in uncertainty interval checks or by transaction commit-wait. We also don't need to push intents above the local HLC, because observed timestamps can now be used to avoid uncertainty with intents up to the intent's local timestamp, which will be set to the local HLC from before the push (see ClockWhilePending). Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/synTimestampTxn
branch
from
51778dc to
3294adb
Compare
arulajmani
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #101938.
This commit removes the handling of synthetic timestamps from the the lock-table waiter. The lock-table waiter used to handle the synthetic timestamp bit in two ways:
Neither of these behaviors are necessary anymore. We don't need to propagate the flag, because it has been deprecated since v22.2 and is no longer consulted in uncertainty interval checks or by transaction commit-wait. We also don't need to push intents above the local HLC, because observed timestamps can now be used to avoid uncertainty with intents up to the intent's local timestamp, which will be set to the local HLC from before the push (see ClockWhilePending).
Release note: None